-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button style to checkbox #3697
Conversation
Hello @QingWei-Li and @Leopoldthecoder What do you think of this PR ? |
This PR is big enough to be shipped with our next minor version. So we'll come back to this before 1.3.0 release. |
Some conflicts came up after #3700. Could you resolve them? Thank you. |
I'm on it to fix and implement new tests. |
b25aba1
to
920c8f5
Compare
Well, after some mistakes with a bad rebase, I think it's ok now. I add the min/max feature on the checkbox button too, and integrate in on an example of checkbox-group buttons. Hope it will be ok. |
Hi, I'll take a look at this later this week. Thank you for your patience. |
Related to #3601
I add
fill
,size
,textColor
props tocheckbox-group
Tell me if you agree with my PR, and if not what I have to change to make you accept it ?
Hope it will help !
Please makes sure these boxes are checked before submitting your PR, thank you!
dev
branch.