-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Carousel] Add an optional label to indicator buttons #4317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a fair point, I didn't think about the default theme. I have added a new prop (defaults to false) for indicator-labels on the carousel itself. If true then it applies another class to the button and adds the label text from carousel-item. Please let me know your thoughts. |
I tried the new commits and got the above. It doesn't seem to be desired. To get what you proposed in #4153, I think more CSS needs to be added. For example, if What do you think? Could you update this PR? |
Updated to fix that issue. Added a class to the |
I updated this. Removed |
Please makes sure these boxes are checked before submitting your PR, thank you!
dev
branch.Adds an optional label to the indicator buttons on the carousel. Can be used only if required like so: