Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimePicker: adjust number position, fixed #4323 #4425

Merged
merged 1 commit into from
Apr 25, 2017
Merged

TimePicker: adjust number position, fixed #4323 #4425

merged 1 commit into from
Apr 25, 2017

Conversation

pengchongfu
Copy link
Contributor

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

when scroll event was ended, adjust the position of number.

see #4323

Leopoldthecoder
Leopoldthecoder approved these changes Apr 25, 2017
View reviewed changes
Copy link
Contributor

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

棒

@Leopoldthecoder Leopoldthecoder merged commit ed4b666 into ElemeFE:dev Apr 25, 2017
@jiaojinqian
Copy link

为啥我更新到v1.3.0-beta.2我这边看到的还是没有解决的？

@killdada
Copy link

更新到1.3.2 vue从2.1.0更新到了2.3.3，好像还是没有解决

@pengchongfu
Copy link
Contributor Author

pengchongfu commented May 11, 2017 •
edited

@jiaojinqian @killdada ，官网的例子可以吗？是不是我们对这个 commit 的理解不一样。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QingWei-Li QingWei-Li QingWei-Li approved these changes

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pengchongfu @jiaojinqian @killdada @QingWei-Li @Leopoldthecoder