Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .sync support for Dialog and Pagination #4539

Merged
merged 1 commit into from
May 3, 2017

Conversation

Leopoldthecoder
Copy link
Contributor

@Leopoldthecoder Leopoldthecoder commented Apr 29, 2017

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@QingWei-Li
Copy link
Contributor

QingWei-Li commented Apr 29, 2017

breaking change?

你 issue 里说的是「新功能」并没有说是 breaking change 所以我理解的话应该兼容老接口

@Leopoldthecoder
Copy link
Contributor Author

Doesn't break anything unless you are using Dialog like

<el-dialog :value="visible">

@baiyaaaaa
Copy link
Contributor

虽然是一个 breaking change, 不过理论上来说,使用 :value="visible" 的应该很少将近没有

@Leopoldthecoder Leopoldthecoder merged commit defd128 into ElemeFE:dev May 3, 2017
@Leopoldthecoder Leopoldthecoder deleted the sync branch May 5, 2017 00:49
@sabakugaara
Copy link
Contributor

sabakugaara commented May 7, 2017

原先用法 v-model="dialogVisble" 升级兼容吗?

@Leopoldthecoder
Copy link
Contributor Author

@sabakugaara 兼容

@sabakugaara
Copy link
Contributor

多谢,请问这种调整,仍然兼容,是 vue2 的机制吗?

@Leopoldthecoder
Copy link
Contributor Author

@sabakugaara Dialog 内部的 v-model 仍然存在,只是改了个名字不再叫 value 了。改名这个 feature 是 Vue 2.2 引入的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants