Slider: add test #508
Merged
Slider: add test #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leopoldthecoder
commented
Oct 19, 2016
| @@ -71,7 +71,7 @@ export default { | |||
| getIframeHTML(domain) { | |||
| let domainScript = ''; | |||
| if (domain) { | |||
| domainScript = `<script>document.domain="${domain}";<` + '/script>'; | |||
| domainScript = '<script' + `>document.domain="${domain}";<` + '/script>'; | |||
There was a problem hiding this comment.
这里我先这样改了一下，确保不报错。
furybean
reviewed
Oct 19, 2016
| window.addEventListener('mousemove', onDragging); | ||
| window.addEventListener('mouseup', onDragEnd); | ||
| }); | ||
| this.$refs.button.addEventListener('mousedown', this.onButtonDown); |
Leopoldthecoder
force-pushed
the
Testing-slider
branch
from
a29be73
to
ee41f74
Compare
Leopoldthecoder
force-pushed
the
Testing-slider
branch
from
ee41f74
to
1330879
Compare
furybean
approved these changes
Oct 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please makes sure these boxes are checked before submitting your PR, thank you!