Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Table: add reserveSelection #517

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Update Table: add reserveSelection #517

merged 1 commit into from
Oct 19, 2016

Conversation

furybean
Copy link
Contributor

@furybean furybean commented Oct 19, 2016 •
edited

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's Contributing Guide.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.
  1. Add rowKey prop for Table.
  2. Add clearSelection method for Table.
  3. Add reserveSelection prop for TableColumn[type="selection"]
    有关于Table组件，当el-table-column组件type="selection"时，怎么手动赋值给checked属性 #324 建议为 Table 组件增加 rowKey 属性 #285

@furybean
Update Table:
3dd5c27 
1. Add rowKey prop for Table.
2. Add clearSelection method for Table.
2. Add reserveSelection prop for TableColumn[type="selection"]
@furybean furybean changed the title Update Table: Update Table: add reserveSelection Oct 19, 2016
@furybean furybean added this to the 1.0.0-rc.8 milestone Oct 19, 2016
QingWei-Li
QingWei-Li approved these changes Oct 19, 2016
View reviewed changes
Copy link
Contributor

@QingWei-Li QingWei-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这么多 breaking change 啊哈哈哈哈

@QingWei-Li QingWei-Li merged commit 6ab0d57 into ElemeFE:master Oct 19, 2016
@furybean furybean deleted the table-prop branch October 19, 2016 13:59
@furybean furybean mentioned this pull request Oct 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QingWei-Li QingWei-Li QingWei-Li approved these changes

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

Assignees
No one assigned
Labels
status: want merge
Projects
None yet
Milestone
1.0.0-rc.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@furybean @QingWei-Li @Leopoldthecoder