Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Add pagination support #7653

Closed
wants to merge 1 commit into from
Closed

Conversation

qidaizhe11
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

由于初衷只是供参考,顺便替用户催一下你们,以期加快你们Table分页功能的开发进度,以下改动选择的基于carbon分支

功能必要性:

如果Pagination和Table分离,在sort/filter后,唯一能做的就是关闭分页器,否则所有的sort/filter都必须custom自行处理,大量定制工作,且大量sort/filter相关代码二次重复,因此Table有必要实现内置的Pagination,以更好的结合sort/filter功能

已知遗留问题:

  • table-layout.js,需添加对pagination的处理(当前固定表头/固定列/流体高度等情况,分页器无法显示)。
  • 相关unit test代码
  • 英文文档
  • 当前中文文档,远程获取数据,我直接用的原生fetch,可能造成浏览器兼容型问题。

@qidaizhe11
Copy link
Contributor Author

#6373

@gustawdaniel
Copy link

@Leopoldthecoder - why this pull request was closed
@qidaizhe11 - can I please to use English, it would be more readable botch for Chinese and rest of world :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants