Fetch and Process Balance Sheet data #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsh has an expansion with '='. if you run `source ./env.sh` in zsh, it will error `zsh: = not found`. Using [[ ]] in the if statement is safer and results in`=` evaluating properly with [[ ]] conditionals.
…bility Make env.sh compatible with zsh
Fix README.md typos
This commit adds react-router so that we can route to other pages, such as the upcoming Bookkeeper Dashboard page. It is set up so that the Header is shared among both the initial aka /home screen and the /bookkeeper screen. A redirect for '/' to '/home/' was added to support this shared header. Tests were written in App.test.tsx for this. There is no discernible difference to a user with this change, other than if they manually navigate to /bookkeeper they will see a blank page. There is no button navigating to /bookkeeper and will not be until it is ready for production. This is so that regular pull request reviews can be done vs having to review a giant pull request with the new bookkeeper dashboard feature. Test dependencies were updated and ts-jest + axios-mock-adapter were added so that components that import axios could be rendered in tests.
- Broke CLNHome and Bookkeeper into their own components - Keeping App smaller with Root component and root router only - Undo typescript downgrade from v5 to v4. - Adding env.sh to gitignore to avoid its future commits
Add react router
The "no transactions helper text" displays two different strings depending on if the node has active channels or not. This commit fixes a bug where these two are backwards and adds tests in CLNTransactionsList.test.tsx.
…tion-channels-text Fix empty transactions channel helper text
- Fixed DateBox test with locale - Fixed timer and canvas warnings - Moved mock data into utilities/test-utilities
…n-fix Adding local env.sh and indentation fixes
Renamed the type Channels to ChannelsDomain since it has extra fields added. ChannelsDto is the response from the network. This was done so it is clear what comes from the network and what is calculated, and to map fields from listpeerchannels into the previous Channel domain model. Removed some fields that are not used and not available in listpeerchannels: direction, max_htlc_value_in_flight_msat, htlc_minimum_msat, last_tx_fee_msat. Other fields were duplicates such as spendable_msatoshi and deleted since spendable_msat exists in listpeerchannels as well as in the original Channels object. use-http sendRequestToStore is now able to handle multiple rpc methods and it bundles the responses together. This allows for sending 2+ rpc calls to 1 state, such as for the new channels AppContextType. Removed the controllers/lightning.ts behavior of checking if listpeers was called and adding node.alias to the response. This was so that the domain layer would handle setting domain data. channels was added as an AppContextType. It combines listpeerchannels and listnodes so that the node aliases can be set to the channels. Added comment to isCompatibleVersion to explain what it does. Added Channels component tests. Update mock store to use channels instead of listChannels.
The code is written as per newer version on CLN. For older CLN nodes, we will collect channels arrays from listPeers.peers array and convert them into newer channels type by adding id as peer_id and connected and peer_connected. Remaining data stays the same.
For eg. changed `satoshi_to_us` to `to_us_sat`, `satoshi_to_them` to `to_them_sat` etc.
…listpeerchannels Update to listpeerchannels
…data Updated the mock data and checks with more realistic dataset
…emoval Remove msatoshi_received, msatoshi, msatoshi_sent from Payments and I…
…-compatble RC version compatibility check
This commit uses the `sql` rpc command to fetch the data for the Balance Sheet. getBalanceSheet() was added to use-http.ts as a standalone function instead of getting it via AppContext so that we can pass parameters more easily to it. TimeGranularity represents the way we should group the data e.g. Monthly, Weekly, Daily. The sql needs to be transformed for the balance sheet, this was done in a new file bookkeeper-transform.ts since it takes some effort. Future transform functions such as for Sats Flow would go in this file. transformToBalanceSheet() is complex because we are limited in what methods we can use in the `sql` rpc call, so I need to do things like grouping and aggregation of credits - debits.
evansmj
force-pushed
the
evansmj/balance-sheet
branch
from
d6ae2fc
to
2fa2372
Compare
|
hey @ShahanaFarooqui no rush on this pr. but for this one i am wondering what you think of the way i handle fetching the sql data and sending it to the components. in the meantime i'll keep tweaking the design. |
…ont want sendRequest()'s in the dependency array
evansmj
force-pushed
the
evansmj/balance-sheet
branch
from
28e80d3
to
10501b6
Compare
Refactor getPeriodKey to reusable function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses the
sqlrpc command to fetch the data for the Balance Sheet.getBalanceSheet() was added to use-http.ts as a standalone function instead of getting it via AppContext so that we can pass parameters more easily to it. TimeGranularity represents the way we should group the data e.g. Monthly, Weekly, Daily.
The sql needs to be transformed for the balance sheet, this was done in a new file bookkeeper-transform.ts since it takes some effort. Future transform functions such as for Sats Flow would go in this file. transformToBalanceSheet() is complex because we are limited in what methods we can use in the
sqlrpc call, so I need to do things like grouping and aggregation of credits - debits.