You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rather than returning a String this should really use the alternate flag on a Formatter, for efficiency reasons. But regardless of efficiency, currently this function just calls Debug instead of Display which does not do the right thing. In particular the "no checksum" output wraps public keys in PublicKey(...).
This method has been made redundant by the `{:#}` display specifier
since 7577e8c two years ago. It is
poorly named, inefficient since it always requires allocating a
`String`, and also broken because it uses debug display for keys.
All of our unit tests were converted over to use :# which is why it
wasn't noticed that this method didn't work.
FixesElementsProject#34FixesElementsProject#85
Rather than returning a
String
this should really use thealternate
flag on aFormatter
, for efficiency reasons. But regardless of efficiency, currently this function just callsDebug
instead ofDisplay
which does not do the right thing. In particular the "no checksum" output wraps public keys inPublicKey(...)
.cc rust-bitcoin/rust-miniscript#477
The text was updated successfully, but these errors were encountered: