Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getnewaddress - don't blind bech32 addresses #1246

Merged
merged 1 commit into from Jul 19, 2023

Conversation

delta1
Copy link
Member

@delta1 delta1 commented Jul 14, 2023

fixes #1245 - getnewaddress will now return an unblinded bech32 address even when -blindedaddresses=1 in config

@apoelstra
Copy link
Member

059a4a6 looks fine to me.

Locally the following tests fail

elements-059a4a> feature_confidential_transactions.py               | ✖ Failed  | 1 s
elements-059a4a> feature_sighash_rangeproof.py                      | ✖ Failed  | 2 s
elements-059a4a> rpc_signrawtransaction.py --legacy-wallet          | ✖ Failed  | 6 s

These look like real failures; they happen consistently.

@delta1
Copy link
Member Author

delta1 commented Jul 19, 2023

Thanks @apoelstra - fixed

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 49c3ea3

@psgreco psgreco merged commit 6802564 into ElementsProject:master Jul 19, 2023
9 of 12 checks passed
@roconnor-blockstream
Copy link
Contributor

Now I'm a bit concerned that this change will break existing workflows of people by unblinding their addresses on thm.

@apoelstra
Copy link
Member

It may, but I think the old behavior was probably wrong. Not sure how best to handle this.

@psgreco
Copy link
Contributor

psgreco commented Jul 19, 2023

I think the old behavior was at least inconsistent, so I'm fine with a comment added to the release notes and this fix making things consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: getnewaddress bech32 returns a blech32 address
4 participants