Update offer for latest spec, make fetchinvoice work better. #4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered by the next test, oops. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: JSONRPC: `listinvoice` no longer crashes if given an invalid (or bolt12) `invstring` argument.
And add the local_offer_id to the schemas too. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-EXPERIMENTAL: JSONRPC: `listoffers` now shows `local_offer_id` when listing all offers.
…ages. This also adds a `fetchinvoice-noconnect` option to suppress it too. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-EXPERIMENTAL: `fetchinvoice` and `sendinvoice` will connect directly if they can't find an onionmessage route. Fixes: ElementsProject#4624
And even if we can't find *ourselves* because we have no channels (we won't be able to pay, sure, but we can request an invoice!). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Makes it easier to post-mortem in the logs. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/more-offers
branch
from
472e15e
to
1901af9
Compare
rustyrussell
force-pushed
the
guilt/more-offers
branch
from
1901af9
to
5108537
Compare
100+ is for experimentation, modern spec practice is to assign feature bits sequentially as PRs get added, to avoid later renumbering. Still respect the old bit for now. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
As per latest spec revision. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-EXPERIMENTAL: BOLT12 offers can now be unsigned, for really short QR codes.
We don't support it (yet), but update the spec to include it. We include the previous field (recurrence_signature) as a shim for the moment, for compat with existing nodes. It's ugly, but next release we'll stop *sending* it, then finally we'll stop accepting it! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…quest. And list it in bolt12-cli decode, and the `decode` command. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…tchinvoice. We don't do it for sendinvoice (yet?). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-EXPERIMENTAL: `fetchinvoice` can take a payer note, and `listinvoice` will show the payer_notes received.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/more-offers
branch
from
5108537
to
a5a9460
Compare
vincenzopalazzo
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
A good walk in the code for me, it takes a couple of hours to try to understand what are happening with the offers :-)
For Github actions error, it looks like an unlucky run, unrelated to this PR.
ack a5a9460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was my work today. And I still haven't fed the chickens!!
Fixes: #4626