Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to build 22.11 on arm32 #5776

Closed
NicolasDorier opened this issue Dec 5, 2022 · 1 comment · Fixed by #5785
Closed

Unable to build 22.11 on arm32 #5776

NicolasDorier opened this issue Dec 5, 2022 · 1 comment · Fixed by #5785
Assignees
@rustyrussell
Milestone
v22.11.1

Comments

@NicolasDorier
Copy link
Collaborator 

plugins/fetchinvoice.c:1362:30: error: conversion from 'long long unsigned int' to 'size_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow]
 1362 |      || tlv_span(wire, 1001, UINT64_MAX, NULL) != 0) {
@NicolasDorier NicolasDorier mentioned this issue Dec 5, 2022
Closed
@rustyrussell rustyrussell added this to the v22.11.1 milestone Dec 5, 2022
@rustyrussell rustyrussell self-assigned this Dec 5, 2022
@rustyrussell
Copy link
Contributor

Good catch! Will fix...

rustyrussell added a commit to rustyrussell/lightning that referenced this issue Dec 5, 2022
@rustyrussell
common: fix arm32 compile breakage.
4d3142d 
It's obviously the incorrect type, while our CI didn't catch it, Nicholas did:

```
plugins/fetchinvoice.c:1362:30: error: conversion from 'long long unsigned int' to 'size_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow]
 1362 |      || tlv_span(wire, 1001, UINT64_MAX, NULL) != 0) {
```

Reported-by: @NicholasDorier
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: Build: arm32 compiler error in fetchinvoice, due to bad types on 32-bit platforms.
Fixes: ElementsProject#5776
@rustyrussell rustyrussell mentioned this issue Dec 5, 2022
Merged
cdecker pushed a commit that referenced this issue Dec 6, 2022
@rustyrussell @cdecker
common: fix arm32 compile breakage.
37590ee 
It's obviously the incorrect type, while our CI didn't catch it, Nicholas did:

```
plugins/fetchinvoice.c:1362:30: error: conversion from 'long long unsigned int' to 'size_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow]
 1362 |      || tlv_span(wire, 1001, UINT64_MAX, NULL) != 0) {
```

Reported-by: @NicholasDorier
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: Build: arm32 compiler error in fetchinvoice, due to bad types on 32-bit platforms.
Fixes: #5776
ddustin pushed a commit to ddustin/lightning that referenced this issue Apr 11, 2023
@rustyrussell @ddustin
common: fix arm32 compile breakage.
f771c8d 
It's obviously the incorrect type, while our CI didn't catch it, Nicholas did:

```
plugins/fetchinvoice.c:1362:30: error: conversion from 'long long unsigned int' to 'size_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow]
 1362 |      || tlv_span(wire, 1001, UINT64_MAX, NULL) != 0) {
```

Reported-by: @NicholasDorier
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: Build: arm32 compiler error in fetchinvoice, due to bad types on 32-bit platforms.
Fixes: ElementsProject#5776
ddustin pushed a commit to ddustin/lightning that referenced this issue May 12, 2023
@rustyrussell @ddustin
common: fix arm32 compile breakage.
9acb449 
It's obviously the incorrect type, while our CI didn't catch it, Nicholas did:

```
plugins/fetchinvoice.c:1362:30: error: conversion from 'long long unsigned int' to 'size_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow]
 1362 |      || tlv_span(wire, 1001, UINT64_MAX, NULL) != 0) {
```

Reported-by: @NicholasDorier
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: Build: arm32 compiler error in fetchinvoice, due to bad types on 32-bit platforms.
Fixes: ElementsProject#5776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
None yet
Projects
None yet
Milestone
v22.11.1
Development

Successfully merging a pull request may close this issue.

common: fix arm32 compile breakage. rustyrussell/lightning
2 participants
@rustyrussell @NicolasDorier