Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macos: Compilation issue with missing fdatasync #6516

Closed
cdecker opened this issue Aug 6, 2023 · 0 comments · Fixed by #6521
Closed

macos: Compilation issue with missing fdatasync #6516

cdecker opened this issue Aug 6, 2023 · 0 comments · Fixed by #6521
Assignees
@rustyrussell
Labels
build mac
Milestone
v23.08

Comments

@cdecker
Copy link
Member

cdecker commented Aug 6, 2023 •
edited

Issue and Steps to Reproduce

I'm trying to compile master @ 620a61e on MacOS via a nix-shell, as that appears to be the most reliable way of creating reproducible builds on MacOS. However, it appears that the recent dynamic configs PR #6303 added a call to fdatasync which may not be available.

Would using fsync be a good alternative? According to the man-pages it is equivalent, but also syncs metadata, so causes more write operations.
@cdecker cdecker added the mac label Aug 6, 2023
@cdecker cdecker added this to the v23.08 milestone Aug 6, 2023
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Aug 7, 2023
@rustyrussell
lightningd: use fsync not fdatasync.
9e5d9d6 
Apparently MacOS doesn't always have fdatasync, so use fsync.  Even more importantly
check whether it succeeds!

Fixes: ElementsProject#6516
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell mentioned this issue Aug 7, 2023
Merged
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Aug 7, 2023
@rustyrussell
lightningd: use fsync not fdatasync.
7754098 
Apparently MacOS doesn't always have fdatasync, so use fsync.  Even more importantly
check whether it succeeds!

Fixes: ElementsProject#6516
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit that referenced this issue Aug 8, 2023
@rustyrussell
lightningd: use fsync not fdatasync.
1fbe87f 
Apparently MacOS doesn't always have fdatasync, so use fsync.  Even more importantly
check whether it succeeds!

Fixes: #6516
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
litch pushed a commit to litch/lightning that referenced this issue Aug 11, 2023
@rustyrussell @litch
lightningd: use fsync not fdatasync.
6faefda 
Apparently MacOS doesn't always have fdatasync, so use fsync.  Even more importantly
check whether it succeeds!

Fixes: ElementsProject#6516
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
build mac
Projects
None yet
Milestone
v23.08
Development

Successfully merging a pull request may close this issue.

lightningd: use fsync not fdatasync. rustyrussell/lightning
3 participants
@cdecker @rustyrussell @vincenzopalazzo