Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reachability test of routehints when channels have htlc_min #6577

Closed
rustyrussell opened this issue Aug 17, 2023 · 0 comments
Closed

Fix reachability test of routehints when channels have htlc_min #6577

rustyrussell opened this issue Aug 17, 2023 · 0 comments
Assignees
@rustyrussell
Labels
pay-plugin routing
Milestone
v23.08

Comments

@rustyrussell
Copy link
Contributor

Can you getroute {id} 1 1 ?

returns no route
however, get route {id} 1000 1 returns a route
and in fact changing this to AMOUNT_MSAT(1000)

lightning/plugins/libplugin-pay.c

Line 2524 in 5531c9d

dijkstra(tmpctx, map, entrynode, AMOUNT_MSAT(1), 1,
fixes the issue for us

Ah, crap, someone has a minimum htlc size I bet!

your right! the second to last hop as min htlc size set
@rustyrussell rustyrussell added this to the v23.08 milestone Aug 17, 2023
@rustyrussell rustyrussell self-assigned this Aug 17, 2023
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Aug 17, 2023
@rustyrussell
pay: don't discard high-htlc_min channels when searching for routehin…
e612121 
…t starts.

As side-effect, getroute(0) is special too.

Reported-by: MiddleW4y in Discord
Fixes: ElementsProject#6577
Changelog-Fixed: `pay` will still use an invoice routehint if path to it doesn't take 1-msat payments.
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Aug 17, 2023
@rustyrussell
pay: don't discard high-htlc_min channels when searching for routehin…
a867259 
…t starts.

As side-effect, getroute(0) is special too.

Reported-by: MiddleW4y in Discord
Fixes: ElementsProject#6577
Changelog-Fixed: `pay` will still use an invoice routehint if path to it doesn't take 1-msat payments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
pay-plugin routing
Projects
None yet
Milestone
v23.08
Development

No branches or pull requests
1 participant
@rustyrussell