Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splice: HSM WIRE_HSMD_SIGN_SPLICE_TX capability not correctly checked #6866

Closed
ksedgwic opened this issue Nov 13, 2023 · 0 comments · Fixed by #6867
Closed

splice: HSM WIRE_HSMD_SIGN_SPLICE_TX capability not correctly checked #6866

ksedgwic opened this issue Nov 13, 2023 · 0 comments · Fixed by #6867
Labels
Milestone

Comments

@ksedgwic
Copy link
Collaborator

Issue and Steps to Reproduce

lightningd/hsm_control.c: 171

	if (feature_offered(ld->our_features->bits[INIT_FEATURE],
			    WIRE_HSMD_SIGN_SPLICE_TX)
	    && !hsm_capable(ld, WIRE_HSMD_SIGN_SPLICE_TX)) {
		fatal("--experimental-splicing needs HSM capable of signing splices!");
	}

our_features->bits[INIT_FEATURE] should be compared to OPT_SPLICE and/or OPT_EXPERIMENTAL_SPLICE instead of the HSMD capabilities flag.

WIRE_HSMD_SIGN_SPLICE_TX is 29, I don't think any option uses that bit

getinfo output

ksedgwic added a commit to lightning-signer/c-lightning that referenced this issue Nov 14, 2023
Fixes ElementsProject#6866

Changelog-Fixed: The WIRE_HSMD_SIGN_SPLICE_TX HSM capability is now correctly checked.
ksedgwic added a commit to lightning-signer/c-lightning that referenced this issue Nov 14, 2023
Fixes ElementsProject#6866

Changelog-Fixed: The WIRE_HSMD_SIGN_SPLICE_TX HSM capability is now correctly checked.
@vincenzopalazzo vincenzopalazzo added this to the v23.11 milestone Nov 14, 2023
rustyrussell pushed a commit that referenced this issue Nov 15, 2023
Fixes #6866

Changelog-Fixed: The WIRE_HSMD_SIGN_SPLICE_TX HSM capability is now correctly checked.
ksedgwic added a commit to lightning-signer/c-lightning that referenced this issue Nov 15, 2023
Fixes ElementsProject#6866

Changelog-Fixed: The WIRE_HSMD_SIGN_SPLICE_TX HSM capability is now correctly checked.
ksedgwic added a commit to lightning-signer/c-lightning that referenced this issue Nov 16, 2023
Fixes ElementsProject#6866

Changelog-Fixed: The WIRE_HSMD_SIGN_SPLICE_TX HSM capability is now correctly checked.
ksedgwic added a commit to lightning-signer/c-lightning that referenced this issue Nov 16, 2023
Fixes ElementsProject#6866

Changelog-Fixed: The WIRE_HSMD_SIGN_SPLICE_TX HSM capability is now correctly checked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants