-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
splice: HSM WIRE_HSMD_SIGN_SPLICE_TX capability not correctly checked #6866
Comments
ksedgwic
added a commit
to lightning-signer/c-lightning
that referenced
this issue
Nov 14, 2023
Fixes ElementsProject#6866 Changelog-Fixed: The WIRE_HSMD_SIGN_SPLICE_TX HSM capability is now correctly checked.
ksedgwic
added a commit
to lightning-signer/c-lightning
that referenced
this issue
Nov 14, 2023
Fixes ElementsProject#6866 Changelog-Fixed: The WIRE_HSMD_SIGN_SPLICE_TX HSM capability is now correctly checked.
rustyrussell
pushed a commit
that referenced
this issue
Nov 15, 2023
Fixes #6866 Changelog-Fixed: The WIRE_HSMD_SIGN_SPLICE_TX HSM capability is now correctly checked.
ksedgwic
added a commit
to lightning-signer/c-lightning
that referenced
this issue
Nov 15, 2023
Fixes ElementsProject#6866 Changelog-Fixed: The WIRE_HSMD_SIGN_SPLICE_TX HSM capability is now correctly checked.
ksedgwic
added a commit
to lightning-signer/c-lightning
that referenced
this issue
Nov 16, 2023
Fixes ElementsProject#6866 Changelog-Fixed: The WIRE_HSMD_SIGN_SPLICE_TX HSM capability is now correctly checked.
ksedgwic
added a commit
to lightning-signer/c-lightning
that referenced
this issue
Nov 16, 2023
Fixes ElementsProject#6866 Changelog-Fixed: The WIRE_HSMD_SIGN_SPLICE_TX HSM capability is now correctly checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue and Steps to Reproduce
lightningd/hsm_control.c: 171
our_features->bits[INIT_FEATURE]
should be compared toOPT_SPLICE
and/orOPT_EXPERIMENTAL_SPLICE
instead of the HSMD capabilities flag.WIRE_HSMD_SIGN_SPLICE_TX
is 29, I don't think any option uses that bitgetinfo
outputThe text was updated successfully, but these errors were encountered: