Added request number based multiplexing to subd
#126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far we were always using the issue order and type to match replies to requests. This has two problems: two concurrent requests with the same type may get mixed up, and there is no way of streaming a multipart response to the requestor, since the request object was being freed after receiving the first reply. This is an attempt at fixing both, by introducing explicit request numbering and flags to signal the end of a reply.
The opening daemon now uses the request/reply muxing. Also pushed the message parsing of opening_open and opening_accept into the handling functions.
|
There is a lingering |
|
Closing for now, it's out of date and we don't currently need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we were always using the issue order and type to match replies
to requests. This has two problems: two concurrent requests with the
same type may get mixed up, and there is no way of streaming a
multipart response to the requestor, since the request object was
being freed after receiving the first reply.
This is an attempt at fixing both, by introducing explicit request
numbering and flags to signal the end of a reply.