DB: more advanced upgrade #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/db-more-advanced-upgrade
branch
from
289a49b
to
4522f62
Compare
Below this code appears: if (current != orig) db_exec(__func__, db, "INSERT INTO db_upgrades VALUES (%i, '%s');", orig, version()); But since the loop pre-increments current, this is always true. I wondered why there were so many duplicates in my db_upgrades table! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
More efficient to measure the ARRAY_SIZE(), which is a runtime constant. We move it into the unit test. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Allow a function as well as (or instead of!) an sql statement. That will let us do things like set per-channel values to the global defaults, for example. Since we remove the NULL termination, the final entry is ARRAY_SIZE()-1 not ARRAY_SIZE()-2. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/db-more-advanced-upgrade
branch
from
4522f62
to
715f280
Compare
niftynei
approved these changes
Feb 25, 2019
|
ACK 715f280 |
Co-Authored-By: rustyrussell <rusty@rustcorp.com.au>
|
Ack c106fe0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor fix, but the second one should help #2342