Add TLV's to decodemsg utility #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup printing methods in devtools/decodemsg such that TLV's can now be printed as well. here's how you'd use it: $ ./devtools/decodemsg --tlv opening_tlv 0120001E020202020202020202020202020202020202020202020202020202020202 > WIRE_OPTION_UPFRONT_SHUTDOWN_SCRIPT (size 32): > shutdown_scriptpubkey=[020202020202020202020202020202020202020202020202020202020202]
rustyrussell
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Not how I would have done it: I would have generated print_tlv_XXX functions and hardcoded them in decodemsg. But this is nicer!
Separately, we should make decodemsg exitcode depend on the message, (and document it in the help!):
- Decoded fine, no surprises, may have extra data (unless
--no-extraspecified). - Truncated, or had extra data and
--no-extrawas specified. - Unknown message.
Making print_xxx return a bitfield (enum for unknown/truncated/extra/ok) is probably simplest implementation.
|
Ack b445b1b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup the
decodemsgutility to also include abilities for TLVs...