openchannel hook #2576
Closed
openchannel hook #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently just segfault when the deserialize function to access resulttok. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This seems like overkill, at least for now. Handling the JSON inline is clearer, for the existing examples at least. We also remove the dummy hook, rather than fix it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
I misunderstood the API, this ended up nesting a result inside the JSON-RPC result. No concerns about backwards compatibility since this is so new. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… error. Without this, the connect command hangs in the next patch. This logic is from the old days when gossipd handled connections, and we wanted to make sure it didn't hang up on this client due to the error. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
For me this happened only under valgrind with test_option_upfront_shutdown_script: ==5063== by 0x51FC076: raise (raise.c:48) ==5063== by 0x51DD534: abort (abort.c:79) ==5063== by 0x1292D2: fatal (log.c:647) ==5063== by 0x116570: channel_set_state (channel.c:340) ==5063== by 0x116E04: lockin_complete (channel_control.c:73) ==5063== by 0x116F15: peer_got_funding_locked (channel_control.c:108) ==5063== by 0x117354: channel_msg (channel_control.c:208) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Instead of lightningd telling us when it's ready, we ask it. This also provides an opportunity to have a plugin hook at this point. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
New fields don't have to be spelled out twice. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/channel-fund-hook
branch
from
34ec153
to
a6f04db
Compare
|
@rustyrussell Uh nice, as I see this is the second part of #2483 that I also was working on. |
|
are you submitting a dedicated PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #2575 (first 4 commits).
I got a bit distracted, as I realized we never implemented the upfront_shutdown_script option. Then I found a weird connect bug. But finally I implemented the damn hook!