Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle reply_channel_range from LND (and enhance gossipwith) #3264

Merged
merged 4 commits into from Nov 18, 2019

Conversation

@rustyrussell
Copy link
Contributor

rustyrussell commented Nov 15, 2019

See lightningnetwork/lnd#3728

Tested and verified on my node, under valgrind.

@rustyrussell rustyrussell requested a review from cdecker as a code owner Nov 15, 2019
@rustyrussell rustyrussell added this to the 0.7.4 milestone Nov 15, 2019
@rustyrussell rustyrussell changed the title Handle reply_channel_range from LND (and enhance gossipd) Handle reply_channel_range from LND (and enhance gossipwith) Nov 15, 2019
if (first_blocknum == peer->range_first_blocknum
&& first_blocknum + number_of_blocks == peer->range_end_blocknum
&& !complete
&& tal_bytelen(msg) == 64046) {

This comment has been minimized.

Copy link
@cdecker

cdecker Nov 17, 2019

Member

Where does this constant come from?

This comment has been minimized.

Copy link
@rustyrussell

rustyrussell Nov 18, 2019

Author Contributor

That's the size of the message LND sends (8000 uncompressed scids). I wanted this workaround to be as narrow as possible to avoid catching real cases.

I always get this wrong, then wonder why it's dying!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Particularly important when talking with modern lnd, which
will hang up on you if you don't offer feature bit 1!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We've been sending them errors for invalid replies; instead, this works
around it.

Changelog-Added: Workaround LND's reply_channel_range issues instead of sending error.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell force-pushed the rustyrussell:gossipwith-tuneup branch from bbcc632 to ced01b3 Nov 18, 2019
@cdecker

This comment has been minimized.

Copy link
Member

cdecker commented Nov 18, 2019

ACK ced01b3

@cdecker cdecker merged commit 6e433e0 into ElementsProject:master Nov 18, 2019
4 checks passed
4 checks passed
bitcoin-bot/acks Acks by cdecker
bitcoin-bot/changelog This PR has at least one changelog entry
bitcoin-bot/fixups PR does not contain unsquashed fixups
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.