Fix HTLCs rexmit out of order #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
approved these changes
Oct 13, 2020
cdecker
force-pushed
the
guilt/htlcs-rexmit-out-of-order
branch
from
d5243d4
to
324b846
Compare
We didn't care, but other implementations (particularly lnd) do. And it does violate the spec. (We need to use skip not xfail on the test which catches this, since xfail doesn't seem to stop errors reported by cleanup) (Includes Christian's typo fix!) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/htlcs-rexmit-out-of-order
branch
from
fed7c71
to
f417840
Compare
[ Includes tidyups by Christian Decker ] Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We had one report of this, and then Eugene and Roasbeef of Lightning Labs confirmed it; they saw misordered HTLCs on reconnection too. Since we didn't enforce this when we receive HTLCs, we never noticed :( Fixes: ElementsProject#3920 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: Protocol: fixed retransmission order of multiple new HTLCs (causing channel close with LND)
rustyrussell
force-pushed
the
guilt/htlcs-rexmit-out-of-order
branch
from
f417840
to
7f4b11e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in this morning's spec call, I tracked it down.