Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyln: add RPCException for finer method failure control. #4279

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

rustyrussell
Copy link
Contributor

@rustyrussell rustyrussell commented Dec 15, 2020

Allows caller to set code and exact message to be returned.

Signed-off-by: Rusty Russell rusty@rustcorp.com.au
Changelog-Added: pyln-client: plugins can now return RPCException for finer control over error returns.

THE BIG QUESTION: RPCException or RpcException?!? 馃槺

Copy link
Collaborator

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0274c75

THE BIG QUESTION: RPCException or RpcException?!? 馃槺

I think RpcException is more idiomatic, but that's no big deal :)

@cdecker
Copy link
Member

cdecker commented Dec 15, 2020

THE BIG QUESTION: RPCException or RpcException?!?

馃槀
The latter is more idiomatic, but both work ok for me :-)

@rustyrussell
Copy link
Contributor Author

Renamed, no other changes.

Allows caller to set code and exact message to be returned.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: pyln-client: plugins can now raise RpcException for finer control over error returns.
@cdecker
Copy link
Member

cdecker commented Dec 16, 2020

ACK 85bd971

Copy link
Collaborator

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK 85bd971

@cdecker cdecker merged commit 7747840 into ElementsProject:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants