feat: peer_connected hook chainable #4351
Conversation
|
I think the first "typo" commit was on purpose, done by @niftynei to differentiate the non-df from the df versions. |
No, I just removed the "_" underscore character, not the "2" in openchannel2. The reason I did that was just to be more conistent with other hook log messages. "_hook" is not part of the name of the hook. |
|
@cdecker The tests to this PR run locally just fine. I will now add missing unit tests that test the chaining of this hook specifically. After this I will undraft this PR... |
m-schmoock
force-pushed
the
feat/chain_hook_peer_connected
branch
from
a53d8a0
to
0175662
Compare
|
Added tests and they are green also with |
|
Rebasing on master which now uses GH actions should now fix the CI breakage! |
Nit: The underscore in "openchannel_hook" is wrong, bcause the name of the hook is just "openchannel". The "_hook" implied this to be part of the name. Changelog-None
Changelog-Changed: peer_connected hook is now chainable
rearranges the`peer_connected_hook_payload` definition to the location where this is used in the file. Fixes certain blanklines and linebreaks to make the code look nicer.
m-schmoock
force-pushed
the
feat/chain_hook_peer_connected
branch
from
6224037
to
af8d56f
Compare
|
Ack af8d56f |
Makes the
peer_connectedhook chainable.Adds feature, doc and tests.