Weekly cleanups #4417
Merged
Weekly cleanups #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were looking for `python` in the `pytest --version` output
The semantics don't change, since `lightningd` will use false as default as well, however setting it to something other than `None` causes the RPC library to include the parameter in the query, and since the parameter was introduced only in 0.9.3 and pyln may be used with older versions this then results in an error about an unknown parameter. Setting this to `None` makes sure pyln filters out the argument before calling. Changelog-Fixed: pyln: Fixed an error when calling `listfunds` with an older c-lightning version causing an error about an unknown `spent` parameter
niftynei
approved these changes
Mar 10, 2021
| # Since we just checked that we have python3 we give that one the | ||
| # most priority and then fall back to some common aliases. | ||
| PYTEST_BINS="python3 -m pytest,pytest,py.test,pytest3,pytest-3" | ||
| IFS=',' |
There was a problem hiding this comment.
Do we need to revert/unset IFS after this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We improve the detection of pytest to prefer
python3 -m pytestover the other executables since it is checked for just
earlier. Also
pytest-3must not be given special treatment sinceit refers to version 3 of pytest (ancient nowadays) not the python3
version of pytest.
Found a regression in
pyln: thespentparameter to thelistfundscall would be always included, which would leadc-lightning versions 0.9.2 and older to complain about an unknown
parameter. Always set these to
Noneso pyln can remove them fromthe call, I didn't catch his in my review.