-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lnprototest with the last version of master #4517
Update lnprototest with the last version of master #4517
Conversation
2e76973
to
37bf2e1
Compare
Fixed #4516
For the actual condition of the lightning unit test only the change inside the lnprototest is required to fix the problem with bitcoin, this is a test that I made with my forks https://github.com/vincenzopalazzo/lightning/runs/2549511882 All stuff is done from my side. Ping @niftynei only for information. |
ffd2dde
to
e42f5e2
Compare
e42f5e2
to
1764d9a
Compare
aec01a9
to
abfbd1c
Compare
There's a problem with the wallet configuration in
Does this PR need to be merged first? https://github.com/rustyrussell/lnprototest/pull/12/files |
Oh I see I missed your comment about how #12 is necessary. Ok. |
Concept ACK, but we're not ready yet on the lnprototest side. |
Yes, When the PR is in the master (lnprototest master) we can have the GitHub action happy again :-) |
OK, I'm merging the lnprototest fixes today, and then I can rebase this and the World Will Be Amazing! (Again)! Thanks @vincenzopalazzo! I've given you commit access to the lnprototest repo too, so you don't have to wait for me next time! |
abfbd1c
to
d5dd480
Compare
d5dd480
to
3a8a56d
Compare
Thanks, Rusty 😸
Rebased on top of the master, let see what GitHub action will says 💺 |
3a8a56d
to
f2f1eb4
Compare
This is a fix propose of the ticket ElementsProject#4516 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
f2f1eb4
to
6f4c14d
Compare
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
6f4c14d
to
dce6e52
Compare
Ack dce6e52 |
I followed the last update of lnprototest and I hope to avoid mistakes with this PR.
The actual version of lnprototest is a couple of comments back, and it missing the update with bitcoin 0.21.0 made by this PR rustyrussell/lnprototest#10.
I made a double-check, and I think that the previous version of lnprototest is fully contained inside the master, with the following PR rustyrussell/lnprototest#5.
Correct me if I'm wrong @niftynei 😄
let see what GitHub action react to this change💺
Closing #4516