Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: listchannels filter by destination #4614

Merged
merged 4 commits into from
Jul 14, 2021
Merged

feat: listchannels filter by destination #4614

merged 4 commits into from
Jul 14, 2021

Conversation

m-schmoock
Copy link
Collaborator

When writing feeadjuster lightningd/plugins#256 I figured there is a usecase for having listchannels be queried also by destination

Adds feature, doc and test.

@m-schmoock m-schmoock requested a review from cdecker as a code owner June 22, 2021 13:45
@m-schmoock m-schmoock force-pushed the feat/listchannels_destination branch 2 times, most recently from d7ffe64 to b89b643 Compare June 22, 2021 13:50
@cdecker
Copy link
Member

cdecker commented Jun 24, 2021

ACK b89b643

@m-schmoock m-schmoock mentioned this pull request Jun 24, 2021
Merged
vincenzopalazzo
vincenzopalazzo approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack b89b643

We need just a rebase on top of the master.

@m-schmoock m-schmoock force-pushed the feat/listchannels_destination branch from b89b643 to 808983a Compare June 25, 2021 07:44
@m-schmoock
Copy link
Collaborator Author

We need just a rebase on top of the master.

done. wait for CI

@m-schmoock
Copy link
Collaborator Author

@vincenzopalazzo
Totally Unrelated to this PR, but on you question in IRC (you dropped out of IRC, hence answer here):

< vincenzopalazzo> mschmoock: About the summary plugin, there is any method to have a json report?

Use lightning-cli -J summary to get JSON output.

@cdecker
Copy link
Member

cdecker commented Jun 25, 2021

ACK 808983a

@niftynei niftynei merged commit 246d230 into ElementsProject:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdecker cdecker cdecker approved these changes

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@m-schmoock @cdecker @vincenzopalazzo @niftynei