funderupdate: add documentation, update some params #4664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
ack 9c1f8ad
Not the best person to ack the documentation, but for me looks good. In addition, the github actions failure seems unrelated to the last change but I think the is still a min_their_funding in the test.
With a quick research, I found the following occurrence
lightning/tests/test_opening.py
Line 1117 in 35bec51
lightning/tests/test_opening.py
Line 1126 in 35bec51
Documentation for the funderupdate command on the funder plugin. Realized we were missing the "leases_only" in the output; also adds '_msat' to msat denominated outputs so they're parsed correctly by our python bindings (also matches our naming conventions) Changelog-EXPERIMENTAL: funder: `funderupdate` command to view and update params for contributing our wallet funds to v2 channel openings. Provides params for enabling `option_will_fund`.
niftynei
force-pushed
the
nifty/funderupdate-docs
branch
from
9c1f8ad
to
64aa609
Compare
|
Yep, missed a test case that used the key. Updated, should be through CI soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for the funderupdate command on the funder plugin.
Realized we were missing the "leases_only" in the output; also adds
'_msat' to msat denominated outputs so they're parsed correctly by our
python bindings (also matches our naming conventions)
Changelog-EXPERIMENTAL: funder:
funderupdatecommand to view and update params for contributing our wallet funds to v2 channel openings. Provides params for enablingoption_will_fund.