Detect and fix stack overflows! #4751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/fix-anchor-outputs-tx-creation-stack-smash
branch
from
9f2a19e
to
5f1bf50
Compare
Seems to be missing the second patch, then again, CI doesn't seem to have an issue with the stronger verification. |
|
The bug was being triggered in a EXPERIMENTAL_DUAL_FUND flow, perhaps the EXPERIMENTAL_FEATURES flag doesn't trigger it? |
This would have caught the bug found in the next commit. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/fix-anchor-outputs-tx-creation-stack-smash
branch
2 times, most recently
from
08913ed
to
2802c42
Compare
|
OK, so I changed it to turn on stronger stack detection always, in configure. Indeed, it broke as expected. Then I pushed the fix, and now it's good. |
users there (and reliably detected now). Reported-by: @larsschenk Reported-by: @nickfarrow Fixes: ElementsProject#4728 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: EXPERIMENTAL: crash for some users while requesting dual funding leases.
rustyrussell
force-pushed
the
guilt/fix-anchor-outputs-tx-creation-stack-smash
branch
from
2802c42
to
401d0c5
Compare
|
ACK 401d0c5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch simple enables CI to find the bug, second fixes it. If there's a third, that means we found more!