channeld: handle reestablish from previous release with EXPERIMENTAL_FEATURES #4830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
backwards-compat-channel-types
branch
from
7328ed4
to
4793eae
Compare
|
This does not work, BTW, since the other peer gets upset! I will alter the spec to change the numbers not to clash... Done. Spec updated. |
rustyrussell
force-pushed
the
backwards-compat-channel-types
branch
from
4793eae
to
13c8d19
Compare
rustyrussell
force-pushed
the
backwards-compat-channel-types
branch
from
13c8d19
to
f0f422f
Compare
|
Drafted and removed from milestone since it cannot be merged as is, due to failure scenarios that weren't considered. |
rustyrussell
force-pushed
the
backwards-compat-channel-types
branch
from
f0f422f
to
1d73e9f
Compare
rustyrussell
force-pushed
the
backwards-compat-channel-types
branch
from
1d73e9f
to
233e19d
Compare
Importantly, this version no longer assumes features 34/35 are unused. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
The latest draft has a feature bit here. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It now uses raw bitfields instead of a subtype, and only allows a single option for any upgrade. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…FEATURES. We switched channel_types from optional to compulsory bits in cb22015. The result is infinite reconnects against older nodes; we reject what they send, and they reject what we send. The simplest fix is to neither send nor receive the (optional!) tlvs unless we both advertize option_quiesce, which we now do. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-EXPERIMENTAL: channel_upgrade draft upgraded: cannot upgrade channels until peers also upgrade.
rustyrussell
force-pushed
the
backwards-compat-channel-types
branch
from
233e19d
to
1c03b19
Compare
|
ACK 1c03b19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switched channel_types from optional to compulsory bits in
cb22015.
The result is infinite reconnects against older nodes.
We needed to upgrade the spec anyway, so I did that, and handle backwards compat.