Fix two small topology issues #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog-Fixed: topology: Under some circumstances we were considering the limits on the wrong direction for a channel
This likely lead to a number of false errors when attempting to route. We deemed a channel to be unusable as soon as either direction isn't usable. This is bad since it excludes not only zeroconf channels (which have different scids for the two directions), but it also excludes any channel that we haven't seen an update from yet. This was likely introduced when attemting to exclude nodes that haven't sent a disable, but their peer has, but this is not necessary as the unresponsive node would be marked as isolated by all its peers, so we don't need to artificially mark a channel direction as disabled when really we can't even enter the node to traverse the channel in that direction. Changelog-Fixed: routing: Fixed an issue where we would exclude the entire channel if either direction was disabled, or we hadn't seen an update yet.
vincenzopalazzo
approved these changes
May 24, 2022
There was a problem hiding this comment.
ACK 85b3efa
I think that !dir and dir make the magic here :) good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these while working on
zeroconfand took me a while to track down:channel_updates from both endpoints, but if that's not the case we'd be unable to use either direction (if A->B is missing/disabled we'd discard the channel right away, if B->A is missing we'd consider the channel, but then read that the maximum number of HTLCs is 0, thus indirectly discarding it too)