pytest: Add grpc based CLN client to test grpc coverage #5362
Commits on Jul 20, 2022
-
msggen: Do not override method names when loading Schema
We were overriding the name right when loading, which is bad since in some languages we use the method name as tag in the requests, thus renaming causes us to call something that isn't defined. Changelog-Fixed: cln-rpc: Fixed a naming mismatch for `ConnectPeer` causing `connectpeer` to be called on the JSON-RPC
-
pytest: Move generated grpc bindings to pyln-testing
These may eventually end up in pyln-client, as they allow talking to the GRPC interface exposed by cln-grpc, however for now they are used for testing only. Once we have sufficient API and test coverage we can move them and leave imports in their place.
-
msggen: Add a new generator for grpc -> python converter
To test the grpc interface we'll want to emulate the JSON-RPC interface as best we can, hence when talking to the grpc interface we want to convert back into a parsed JSON format as LightningRpc would have returned it. This is just the simplest way of closing the loop here: ``` pyln-testing --grpc-> cln-grpc --grpc2json ^ | | v | JSON-RPC | | TEST v ^ CLN | | | v pyln-testing <-grpc2py-- cln-grpc <- json2grpc ``` -
pytest: Add a new RPC interface to talk to grpc
This allows us to re-use existing tests (assuming the call and fields are covered by `cln-rpc` and `cln-grpc`) to test the full roundtrip from test over the grpc interface to the json-rpc interface and back again. You can switch to the grpc interface by setting the `CLN_TEST_GRPC` environment variable to 1, but for now only very few shims are implemented (due to the non-generated nature of LightningRpc).
-
-
cln-grpc: Skip serializing fields when Option<Vec<T>> is empty too
The CLN API is rather strict about the fact that we should skip providing a field whenever it is empty. Checking for `is_none` would still include empty arrays. Changelog-Fixed cln-rpc: Optional empty arrays will no longer be serialized in requests
-
cln-plugin: Notify waiting tasks if the lightningd connection closes
This is usually a signal that lightningd is shutting down, so notify any instance that is waiting on `plugin.join()`. Changelog-Fixed: cln-plugin: Fixed an issue where plugins would hang indefinitely despite `lightningd` closing the connection
-
msggen: Add
stopmethod to generatorsWe'll need this when testing the grpc interface in pyln-testing, otherwise tests just slowly die and wither.
-
pyln-testing: Add a couple of methods used in tests
These are the most used methods in tests, so we can start getting our test coverage up.
-
-
msggen: Ignore
state_changesin grpc2pyIt's being skipped in grpc so we don't have it later anyway.
-
-
-
-
-
schema: Add missing
mindepthargument tofundchannelThis was likely missed during the zeroconf PR. Changelog-None
-
