keysend: just strip even unknown fields. #5645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: Plugins: `keysend` now removes unknown even (technically illegal!) fields, to try to accept more payments.
cdecker
reviewed
Oct 4, 2022
Comment on lines
+272
to
+273
| * (Keysend is not a design, it's a kludge by people who | ||
| * didn't read the spec, and Just Made Something Work). */ |
|
Oh wow, this is heavy handed, but I get it. The odd-is-ok in TLV has been pretty much sidestepped by applications that didn't bother reading the how and why in the spec, and now we're getting punished for being spec-compliant... 😢 ACK 9459d22 |
cdecker
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had reports of keyends failing, and indeed:
Sure, we've made accepting weird TLVs a non-experimental option, but surely it's better to only (and automatically!) accept them in the keysend plugin where the problem is?
Signed-off-by: Rusty Russell rusty@rustcorp.com.au
Changelog-Fixed: Plugins:
keysendnow removes unknown even (technically illegal!) fields, to try to accept more payments.