Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireaddr: extend is_dnsaddr testcase a bit #5777

Conversation

m-schmoock
Copy link
Collaborator

@m-schmoock m-schmoock commented Dec 5, 2022

My little nothing patch :)
This extends the testcase for is_dnsaddr for a case that came up in issue #5657

Also fixes a typo in a comment.

Changelog-None

My little nothing path :)
This extends the testcase for is_dnsaddr for a case that came up
in issue ElementsProject#5657 ElementsProject#5657

Also fixes a typo in a comment.

Changelog-None
@m-schmoock m-schmoock closed this Dec 5, 2022
@m-schmoock
Copy link
Collaborator Author

m-schmoock commented Dec 5, 2022

Will re-submit an updated version of this tomorrow.
I think we should allow _ underscore in the hostname part of a DNS FQDN name.
See discussion with @whitslack in #5657 (comment)

@m-schmoock m-schmoock deleted the chore/extend_dns_testcase branch December 6, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant