Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last(?) Updates to dual-funding Spec #5956

Merged
merged 4 commits into from Feb 8, 2023
Merged

Last(?) Updates to dual-funding Spec #5956

merged 4 commits into from Feb 8, 2023

Commits on Feb 8, 2023

  1. rfc-dual-fund: update to latest spec for dual-funding 

    - Renamed zerod_channel_ids to temporary_channel_id
- Renamed witness_stack->witnesses
- Renamed witness_element->witness_elements
- open_channel2 now includes second commitment point
- accept_channel2 now includes second commitment point

Current commit on rfc branch 64f7f360b9f3c2664d078e2129cfe83098fc4617

Changelog-EXPERIMENTAL: Protocol: dual-funding spec changed in incompatible ways, won't work with old versions (but maybe soon with Eclair!!)
    @niftynei @rustyrussell
    niftynei authored and rustyrussell committed Feb 8, 2023
    Copy the full SHA
    2dba51f View commit details
    Browse the repository at this point in the history

  2. df: fetch both the first+second commitment point 

    Ignore the sent back second commitment point that we get; we'll get it
again at `channel_ready`.
    @niftynei @rustyrussell
    niftynei authored and rustyrussell committed Feb 8, 2023
    Copy the full SHA
    3833aa5 View commit details
    Browse the repository at this point in the history

  3. df: remove minimum witness weight for input calculations 

    We can't know how much taproot etc inputs weight will be, so we just
make sure that a peer covers the known bytes, at least.
    @niftynei @rustyrussell
    niftynei authored and rustyrussell committed Feb 8, 2023
    Copy the full SHA
    6bb55bc View commit details
    Browse the repository at this point in the history

  4. df: remove static remote key dependency 

    Must be negotiated independently.

Requested-By: @t-bast
    @niftynei @rustyrussell
    niftynei authored and rustyrussell committed Feb 8, 2023
    Copy the full SHA
    c7d8c29 View commit details
    Browse the repository at this point in the history