listclosedchannels command #5967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
approved these changes
Mar 18, 2023
There was a problem hiding this comment.
ACK 4e61134
Looks that the conflicts are just trivial on top of some docs file
rustyrussell
force-pushed
the
guilt/keep-closed-channels
branch
from
4e61134
to
24d5aae
Compare
We actually have an assertion that there are no channels remaining when we delete peers, so this is confusing! Actually removing the constraint is db-specific and deeply non-trivial. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This relaxes the assertion that it won't be used, and renames the function to be clear. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…se channel. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We used to have a text version, so this was named 'scid'. Fix it now. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We don't cover three common patterns: 1. Optional integers (db_col_u64 has different form from structs) 2. Optional strings. 3. Optional array fields. But it does neaten and reduce the scope for cut&paste errors in the common "if not-NULL, tal and assign". Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This doesn't restore every bit of information we have, but it does contain the important ones. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
i.e. recurse properly in SQL generation. This is about to happen. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We didn't handle the case of an array inside a subobject. But that happens when we add the next commit! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: JSON-RPC: `listpeerchannels` now has `channel_type` field. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: JSON-RPC: `listclosedchannels` to show old, dead channels we previously had with peers. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: JSON-RPC: `sql` now includes `listclosedchannels`.
rustyrussell
force-pushed
the
guilt/keep-closed-channels
branch
from
24d5aae
to
824b70e
Compare
vincenzopalazzo
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we leave closed channels in the db, but forget the peer. This fixes that, and gives access to such historic channels.
Fixes #4734