listpeers: add num_channels #5968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will save a lot of RPC ping/pong when plugins still need to iterate both, `listpeers` and `listpeerchannels`. When `num_channels` is 0 they can skip additional calls. Changelog-Added: RPC `listpeers` output now has `num_channels`.
|
Q: Is there a helper to count a list instead of |
m-schmoock
force-pushed
the
listpeers/num_channels
branch
from
1d51711
to
c5f1780
Compare
rustyrussell
approved these changes
Feb 7, 2023
|
There was just a typo in the schema that I force pushed right now... |
|
@rustyrussell Can we have this in 23, because otherwise I need ugly if/else code everywhere in the plugins when it comes to |
m-schmoock
force-pushed
the
listpeers/num_channels
branch
from
c5f1780
to
655e8d1
Compare
m-schmoock
force-pushed
the
listpeers/num_channels
branch
from
655e8d1
to
bc99d0a
Compare
m-schmoock
force-pushed
the
listpeers/num_channels
branch
2 times, most recently
from
74cf899
to
99d9629
Compare
m-schmoock
force-pushed
the
listpeers/num_channels
branch
from
99d9629
to
b8d78ab
Compare
m-schmoock
commented
Feb 7, 2023
cdecker
requested changes
Feb 7, 2023
m-schmoock
force-pushed
the
listpeers/num_channels
branch
from
51d56c4
to
461a5fa
Compare
m-schmoock
force-pushed
the
listpeers/num_channels
branch
from
461a5fa
to
2bdc819
Compare
|
Ack 2bdc819 |
|
ACK 2bdc819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be helpful for plugins and because of the
listpeerchannelslistpeerssplit, so that we can reduce unnecessary RPC ping/pong calls whennum_channelsis 0.A lot of plugins still need to iterate both calls, so then they can save some IO load and delays.