Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: fetchinvoice: assign the quantity to the invrequest field #6090

Merged

Commits on Mar 20, 2023

  1. plugin: fetchinvoice: set the quantity in invreq

    While the user trying to fetch an invoice by specifing the quantity we do
    not work as expected.
    
    Running the command
    
    ```
    lightning-cli fetchinvoice -k offer='lno1qgsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzrcgqffqszsk2p6hycmgv9ek2grpyphxjcm9ypmkjer8v46pyzmhd9jxwet5wvhxxmmdzsqs593pq0ylsvakdua5h976f4g3eautgjt3udvtyga47eaw7339sjrhpwpwz' quantity=2
    ```
    
    and we answer back with
    
    ```json
    {
       "code": -32602,
       "message": "quantity parameter required"
    }
    ```
    
    This is caused because we forget to bind the `quanity` field from the
    RPC into the `invrequest`.
    
    Reported-by: @aaronbarnardsound
    Link: ElementsProject#6089
    Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
    Changelog-EXPERIMENTAL: fetchinvoice: fix: do not ignore the `quantity` field
    into the invreq field.
    vincenzopalazzo committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    acf71ae View commit details
    Browse the repository at this point in the history