plugin: autoclean: cleanup the forwards with localfailed #6109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
requested changes
Mar 22, 2023
vincenzopalazzo
force-pushed
the
macros/autoclean_local_failed
branch
2 times, most recently
from
3a6f655
to
745759c
Compare
While we are cleaning up the list forwards with the autoclean plugin we are not taking into count the forward's payments with the status set to `local_failed`. In this case, the forwards have no resolved time because it was not resolved by us due to some local error. So, this commit is fixing the auto clean plugin by allowing to delete of the forwards with status set to local_failed by taking into count the received_time, with the assumption that the received_time, in this case, is equal to the resolved time (?) Reported-by: @denis2342 Link: ElementsProject#6058 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> Changelog-Fixed: plugin: autoclean: considerer the forwards with status set to `local_failed`.
vincenzopalazzo
force-pushed
the
macros/autoclean_local_failed
branch
from
745759c
to
4d5300c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we are cleaning up the list forwards with the autoclean plugin we are not taking into count the forward's payments with the status set to
local_failed. In this case, the forwards have no resolved time because it was not resolved by us due to some local error.So, this commit is fixing the auto clean plugin by allowing to delete of the forwards with status set to local_failed by taking into count the received_time, with the assumption that the received_time, in this case, is equal to the resolved time (?)
Reported-by: @denis2342
Link: #6058
Signed-off-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com
Changelog-Fixed: plugin: autoclean: considerer the forwards with status set to
local_failed.Fixes #6058