Zero fee htlc prep #4: channel types everywhere, with protocol fixes :( #6136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
zero-fee-htlc-prep-4
branch
2 times, most recently
from
a6e630c
to
a463a62
Compare
cdecker
approved these changes
Apr 6, 2023
rustyrussell
force-pushed
the
zero-fee-htlc-prep-4
branch
from
a463a62
to
e573825
Compare
Commonalizes a small piece of code. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Happens more than I expected! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1. anchor_to_remote_redeem => bitcoin_wscript_to_remote_anchored, which matches other witness script producing functions and makes it clear that it's a to_remote variant. 2. is_anchor_witness_script => is_to_remote_anchored_witness_script makes it clear that it's about a to_remote output (as altered when anchors are enabled) not an anchor output! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…is too low. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This was confusing! We reported every second one. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It will append inputs to this PSBT instead of allocating a new one. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
I tested this indeed breaks if we don't accept it, then implemented the code to accept it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: protocol: We now correctly accept the `option_scid_alias` bit in `open_channel` `channel_type`. Changelog-Deprecated: protocol: Not setting `option_scid_alias` in `option_channel` `channel_type` for unannounced channels.
… really zeroconf. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: Protocol: we will upfront reject channel_open which asks for a zeroconf channel unless we are going to do a zerconf channel.
This was always the intent, but now we have to reconstruct from the disparate fields. This means `option_anchor_outputs` is now redundant. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…ons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
zero-fee-htlc-prep-4
branch
from
e573825
to
709c4ae
Compare
|
Trivial rebase onto master to remove conflicts now previous is merged. Ack 709c4ae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #6120 so start fromMERGED!lightningd: expose default_locktime for wider usage.This puts channel_type in the db, rather than using separate flags, but doing so revealed that we didn't use it properly in several places. Those have been fixed, but some of it cannot be done immediately as that would break older nodes. @cdecker in particular will want to review this!