Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feerate docs #6170

Merged
merged 2 commits into from Apr 11, 2023
Merged

Conversation

rustyrussell
Copy link
Contributor

No description provided.

mempool.info gives sat/vB, which is 1000 too low for us!

See-also: ElementsProject#6161 (complains setting feerate to 5 doesn't work)

See-also: ElementsProject#6129
Suggested-by: @lightingorb
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…-block.

Turns out this was accidentally changed for v0.10.1 in
d8e6889 where we made fee levels less
aggressive.

Oops.  I guess we can fix the docs.  And we now have "2blocks" if you
want it really fast!

Closes: ElementsProject#6129
Changelog-Fixed: JSON-RPC: `feerates` document correctly that urgent means 6 blocks (not 2), and give better feerate examples.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell added this to the v23.05 milestone Apr 11, 2023
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ca5976a

@ShahanaFarooqui ShahanaFarooqui merged commit 3f95b55 into ElementsProject:master Apr 11, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fundchannel with feerate=urgent leads to transaction getting stuck in mempool
3 participants