Remove --daemon from lightningd.service #6377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `--daemon` flag is used, `lightningd` requires that `--log-file` is used as well. By consequence, the `lightningd.service` didn't work out-of-the-box for me. This changes also sends the logs to `journald`. The new approach is consistent with the `bitcoind.service` file in the bitcoin-core repository. I prefer this approach because it comes with automatic log-rotation.
|
The tests failed but I don't see relation between the failed tests and my code. Is it possible this is a flakey test. If yes, can anyone run it again? |
Yah it is :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
--daemonflag is used,lightningdrequires that--log-fileis used as well. By consequence, thelightningd.servicedidn't work out-of-the-box for me.This changes also sends the logs to
journald.The new approach is consistent with the
bitcoind.servicefile in the bitcoin-core repository.I prefer this approach because it comes with automatic log-rotation.