Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications neaten format #6388

Merged
merged 7 commits into from
Jul 10, 2023
Merged

Notifications neaten format #6388

merged 7 commits into from
Jul 10, 2023

Commits on Jul 7, 2023

  1. notification: connect with json key connect

    @ShahanaFarooqui @rustyrussell
    ShahanaFarooqui authored and rustyrussell committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    e2c610d View commit details
    Browse the repository at this point in the history

  2. notification: disconnect with json key disconnect 

    Changelog-Added: JSON-RPC: `connect` and `disconnect` notifications now wrap `id` field in a `connect`/`disconnect` object (consistency with other notifications)
    @ShahanaFarooqui @rustyrussell
    ShahanaFarooqui authored and rustyrussell committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    84490f9 View commit details
    Browse the repository at this point in the history

  3. notification: block_added json key updated from block to block_added 

    Changelog-Added: JSON-RPC: `block_added` notification wraps fields in `block_added` object (notification consistency)
    @ShahanaFarooqui @rustyrussell
    ShahanaFarooqui authored and rustyrussell committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    7293c33 View commit details
    Browse the repository at this point in the history

  4. doc: Typo in balance_snapshot notification object

    @ShahanaFarooqui @rustyrussell
    ShahanaFarooqui authored and rustyrussell committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    857a243 View commit details
    Browse the repository at this point in the history

  5. tests: notification response fixes 

    tests: notification response fixes
    @ShahanaFarooqui @rustyrussell
    ShahanaFarooqui authored and rustyrussell committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1161ff5 View commit details
    Browse the repository at this point in the history

  6. plugins: update for new deprecation API where all fields are nicely w… 

    …rapped.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    05c56be View commit details
    Browse the repository at this point in the history

  7. lightningd: actually deprecate old notification fields now tests and … 

    …plugins are all updated.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Deprecated: JSON-RPC: `connect`, `disconnect` and `block_added` notification fields outside the same-named object (use .connect/.disconnect/.block_added sub-objects)
    @ShahanaFarooqui @rustyrussell
    ShahanaFarooqui authored and rustyrussell committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    f6d8b04 View commit details
    Browse the repository at this point in the history