Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't gossip about recently-closed channels #6413

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Don't gossip about recently-closed channels #6413

merged 4 commits into from
Jul 20, 2023

Commits on Jul 19, 2023

  1. gossip_store: add "dying" flag to indicate not to gossip dying channels. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    3a1166f View commit details
    Browse the repository at this point in the history

  2. gossipd: add dying marker to channel_announcement/channel_update. 

    We don't actually delete them for 12 blocks, but we can't avoid
propagating them.  We don't mark node_announcements, which is a bit
weird, but avoids us tracking logic to un-dying them if a channel is
opened.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    368f0e8 View commit details
    Browse the repository at this point in the history

  3. pytest: test for whether we gossip spent channels. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    649ae79 View commit details
    Browse the repository at this point in the history

  4. connectd: don't gossip dying channels. 

    Fixes: ElementsProject#6368
Changelog-Fixed: Protocol: we no longer gossip about recently-closed channels (Eclair gets upset with this).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    00b8bc9 View commit details
    Browse the repository at this point in the history