channeld: don't close connection on invalid badonion code (LND bug?) #6425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` channeld WARNING: Bad update_fail_malformed_htlc failure code 4103 ``` Warren Togami reports this happening with Bitrefill on every reconnect, so it's clearly something LND does. (4103 is TEMPORARY_CHANNEL_FAILURE, which does not belong in update_fail_malformed_htlc). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: Protocol: We allow update_fail_malformed_htlc with invalid error codes (LND?)
Confirmed this patch cherry-picked upon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warren Togami reports this happening with Bitrefill on every reconnect, so it's clearly something LND does.
(4103 is TEMPORARY_CHANNEL_FAILURE, which does not belong in update_fail_malformed_htlc).
Changelog-Changed: Protocol: We allow update_fail_malformed_htlc with invalid error codes (LND?)