pay: Annotate both local alias and real scid with channel hints #6428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debugging a number of payments showed that we sometimes waste a number of attempts routing through a channel via its alias, rather than its scid. This is because while we annotate the scid when it has been set, we do not do so for the alias. The alias then is picked for routing despite not having enough capacity, failing the attempt locally. It can also happen that we alternate between scid and alias, doubling the number of failed attempts before we can make progress. This patch sets the hint for the alias to a capacity of 0 and disables it as if the peer were offline. This means when available we'll always use the scid, which is also far easier to read in the logs. Changelog-Fixed: pay: We now track spendable amounts when routing on both the local alias as well as the short channel ID
cdecker
force-pushed
the
20230723-pay-alias-disable
branch
3 times, most recently
from
3551129
to
4e67a15
Compare
The channel selection did not consider the amounts that we are trying to transfer, which in a multiplexed channel world could end up always selecting a channel that is too small for the payment. We also log which channel was selected based on the selector that is passed in, allowing us to better follow the decisions. Changelog-Fixed: pay: `sendonion` and `sendpay` will now consider amounts involved when using picking one channel for a peer
cdecker
force-pushed
the
20230723-pay-alias-disable
branch
from
4e67a15
to
b2dd282
Compare
cdecker
added a commit
to cdecker/lightning
that referenced
this pull request
Jul 27, 2023
The alias may not be set for non-alias channels after they confirm. The other branch is safe because we only consider active channels. Changelog-None Fixes ElementsProject#6450
rustyrussell
pushed a commit
that referenced
this pull request
Jul 28, 2023
The alias may not be set for non-alias channels after they confirm. The other branch is safe because we only consider active channels. Changelog-None Fixes #6450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging a number of payments showed that we sometimes waste a number of attempts routing through a channel via its alias, rather than its scid. This is because while we annotate the scid when it has been set, we do not do so for the alias. The alias then is picked for routing despite not having enough capacity, failing the attempt locally.
It can also happen that we alternate between scid and alias, doubling the number of failed attempts before we can make progress.
This patch sets the hint for the alias to a capacity of 0 and disables it as if the peer were offline. This means when available we'll always use the scid, which is also far easier to read in the logs.
Changelog-Fixed: pay: We now track spendable amounts when routing on both the local alias as well as the short channel ID