Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msggen: Add staticbackup mapping #6507

Merged

Conversation

cdecker
Copy link
Member

@cdecker cdecker commented Aug 4, 2023

We want to expose this on cln-grpc for remote backups.

Notice that the type of StaticBackup.scb[] changed from string to hex since the string actually represents a hex-encoded binary TLV. I hope no other tooling relies on this.

This makes them smaller when passing them over a binary-capable encoding.
Changelog-Added: cln-grpc: Added `staticbackup` support to cln-grpc
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed this! The man page is not autogenerated! I'll fix this too!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 613d9ce

@rustyrussell rustyrussell merged commit 3191ff7 into ElementsProject:master Aug 6, 2023
39 checks passed
@rustyrussell rustyrussell added this to the v23.08 milestone Aug 6, 2023
@cdecker cdecker deleted the 20230804-grpc-staticbackup branch August 7, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants