Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renepay refactors and cleanups #6538

Merged
merged 22 commits into from
Aug 12, 2023
Merged

Renepay refactors and cleanups #6538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2e1d6c3
renepay: remove unused all_flows field.
rustyrussell Aug 9, 2023
8c0e4fe
renepay: remove attempt limit.
rustyrussell Aug 9, 2023
9fe203e
renepay: fix localmods.
rustyrussell Aug 9, 2023
70042fe
renepay: use more formal allocator pattern.
rustyrussell Aug 10, 2023
52260c6
renepay: move list_node to first member of struct payment.
rustyrussell Aug 10, 2023
dccf487
renepay: make memleak simpler.
rustyrussell Aug 10, 2023
698f415
renepay: merge `struct renepay` and `struct payment` into one.
rustyrussell Aug 10, 2023
fa90e58
renepay: get max group_id in single iteration.
rustyrussell Aug 10, 2023
2b813ac
renepay: simplify JSON handling.
rustyrussell Aug 10, 2023
775cebc
renepay: simplify JSON handling in notification_sendpay_success.
rustyrussell Aug 10, 2023
0fb46e1
renepay: don't re-parse bolt11 to get routehints.
rustyrussell Aug 10, 2023
e1da480
renepay: put the entire hash in the key struct.
rustyrussell Aug 10, 2023
149057f
renepay: remove unused result member.
rustyrussell Aug 10, 2023
99f331e
renepay: remove always-true "first_time" and "unlikely_ok" flags.
rustyrussell Aug 10, 2023
c358b56
renepay: fix up handling of errors from final node.
rustyrussell Aug 10, 2023
e4b386f
renepay: make pay_plugin a tal object.
rustyrussell Aug 10, 2023
8cdef9a
renepay: grab update from WIRE_TEMPORARY_CHANNEL_FAILURE if present.
rustyrussell Aug 10, 2023
a578732
renepay: drive *all* progress from termination of struct pay_flow.
rustyrussell Aug 10, 2023
d4ea3da
renepay: add dummy pf_resuly type to ensure we deal with the flow.
rustyrussell Aug 10, 2023
07d78c9
renepay: do less work in destroy_pay_flow, and reorder pay_flow.c
rustyrussell Aug 10, 2023
a64a6ba
renepay: trivial cleanup to rename `flow` to `pf` everywhere.
rustyrussell Aug 10, 2023
4f25609
renepay: add command notifications
rustyrussell Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions common/test/run-bolt12_merkle-json.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ void towire_channel_id(u8 **pptr UNNEEDED, const struct channel_id *channel_id U
/* Generated stub for towire_node_id */
void towire_node_id(u8 **pptr UNNEEDED, const struct node_id *id UNNEEDED)
{ fprintf(stderr, "towire_node_id called!\n"); abort(); }
/* Generated stub for towire_s64 */
void towire_s64(u8 **pptr UNNEEDED, s64 v UNNEEDED)
{ fprintf(stderr, "towire_s64 called!\n"); abort(); }
/* Generated stub for towire_secp256k1_ecdsa_signature */
void towire_secp256k1_ecdsa_signature(u8 **pptr UNNEEDED,
const secp256k1_ecdsa_signature *signature UNNEEDED)
Expand All @@ -67,9 +70,6 @@ void towire_u32(u8 **pptr UNNEEDED, u32 v UNNEEDED)
/* Generated stub for towire_u64 */
void towire_u64(u8 **pptr UNNEEDED, u64 v UNNEEDED)
{ fprintf(stderr, "towire_u64 called!\n"); abort(); }
/* Generated stub for towire_s64 */
void towire_s64(u8 **pptr UNNEEDED, s64 v UNNEEDED)
{ fprintf(stderr, "towire_s64 called!\n"); abort(); }
/* Generated stub for towire_u8 */
void towire_u8(u8 **pptr UNNEEDED, u8 v UNNEEDED)
{ fprintf(stderr, "towire_u8 called!\n"); abort(); }
Expand Down
6 changes: 0 additions & 6 deletions common/test/run-json_remove.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@ u32 fromwire_u32(const u8 **cursor UNNEEDED, size_t *max UNNEEDED)
/* Generated stub for fromwire_u64 */
u64 fromwire_u64(const u8 **cursor UNNEEDED, size_t *max UNNEEDED)
{ fprintf(stderr, "fromwire_u64 called!\n"); abort(); }
/* Generated stub for fromwire_s64 */
s64 fromwire_s64(const u8 **cursor UNNEEDED, size_t *max UNNEEDED)
{ fprintf(stderr, "fromwire_s64 called!\n"); abort(); }
/* Generated stub for fromwire_u8 */
u8 fromwire_u8(const u8 **cursor UNNEEDED, size_t *max UNNEEDED)
{ fprintf(stderr, "fromwire_u8 called!\n"); abort(); }
Expand Down Expand Up @@ -187,9 +184,6 @@ void towire_u32(u8 **pptr UNNEEDED, u32 v UNNEEDED)
/* Generated stub for towire_u64 */
void towire_u64(u8 **pptr UNNEEDED, u64 v UNNEEDED)
{ fprintf(stderr, "towire_u64 called!\n"); abort(); }
/* Generated stub for towire_s64 */
void towire_s64(u8 **pptr UNNEEDED, s64 v UNNEEDED)
{ fprintf(stderr, "towire_s64 called!\n"); abort(); }
/* Generated stub for towire_u8 */
void towire_u8(u8 **pptr UNNEEDED, u8 v UNNEEDED)
{ fprintf(stderr, "towire_u8 called!\n"); abort(); }
Expand Down
14 changes: 4 additions & 10 deletions lightningd/test/run-invoice-select-inchan.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,10 @@ void json_add_num(struct json_stream *result UNNEEDED, const char *fieldname UNN
void json_add_preimage(struct json_stream *result UNNEEDED, const char *fieldname UNNEEDED,
const struct preimage *preimage UNNEEDED)
{ fprintf(stderr, "json_add_preimage called!\n"); abort(); }
/* Generated stub for json_add_s64 */
void json_add_s64(struct json_stream *result UNNEEDED, const char *fieldname UNNEEDED,
int64_t value UNNEEDED)
{ fprintf(stderr, "json_add_s64 called!\n"); abort(); }
/* Generated stub for json_add_secret */
void json_add_secret(struct json_stream *response UNNEEDED,
const char *fieldname UNNEEDED,
Expand Down Expand Up @@ -544,10 +548,6 @@ void json_add_u32(struct json_stream *result UNNEEDED, const char *fieldname UNN
void json_add_u64(struct json_stream *result UNNEEDED, const char *fieldname UNNEEDED,
uint64_t value UNNEEDED)
{ fprintf(stderr, "json_add_u64 called!\n"); abort(); }
/* Generated stub for json_add_s64 */
void json_add_s64(struct json_stream *result UNNEEDED, const char *fieldname UNNEEDED,
int64_t value UNNEEDED)
{ fprintf(stderr, "json_add_s64 called!\n"); abort(); }
/* Generated stub for json_add_uncommitted_channel */
void json_add_uncommitted_channel(struct json_stream *response UNNEEDED,
const struct uncommitted_channel *uc UNNEEDED,
Expand Down Expand Up @@ -798,12 +798,6 @@ struct command_result *param_u64(struct command *cmd UNNEEDED, const char *name
const char *buffer UNNEEDED, const jsmntok_t *tok UNNEEDED,
uint64_t **num UNNEEDED)
{ fprintf(stderr, "param_u64 called!\n"); abort(); }
/* Generated stub for channel_state_normalish */
bool channel_state_normalish(const struct channel *channel UNNEEDED)
{ fprintf(stderr, "channel_state_normalish called!\n"); abort(); }
/* Generated stub for channel_state_awaitish */
bool channel_state_awaitish(const struct channel *channel UNNEEDED)
{ fprintf(stderr, "channel_state_awaitish called!\n"); abort(); }
/* Generated stub for peer_any_active_channel */
struct channel *peer_any_active_channel(struct peer *peer UNNEEDED, bool *others UNNEEDED)
{ fprintf(stderr, "peer_any_active_channel called!\n"); abort(); }
Expand Down