Fix gossip flood from self-advertizement #6546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…els. dump_our_gossip() is mainly useful for propagating our gossip when we are poorly connected, not when we have many peers. @whitslack reported excessive memory use queueing messages on a large node, so we limit it beyond the first 5 peers, to 5 channels each. This assumes we have ~ the same number of peers as channels, which is probably reasonable. In the long term, we should move this to connectd, which is properly equipped to trickle out these messages. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#6540
endothermicdev
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Looks good to me. I like that the full gamut is streamed to the first 5 peers. (I was getting ready to do some statistics before realizing this.)
ACK 232967d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fun one, but I got to implement Fischer-Yates shuffle!