Renepay fixes #6632
Merged
Renepay fixes #6632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rustyrussell
commented
Aug 29, 2023
rustyrussell
commented
- Fix cltv usage across the path.
- Make shadow code work.
This happened while I was hacking (it shouldn't normally!): cmd here is NULL. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…nfo. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1. When we add a shadow amount, we were using the wrong channel for the fee calculation. 2. Similarly, when calculating the delay amount. The result is that we can get WIRE_INCORRECT_CLTV_EXPIRY repeatedly from nodes. Reported-by: https://github.com/Sjors Fixes: ElementsProject#6620 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changlog-Experimental: Fixed: `renepay` handles ctlv correctly when it varies along a path.
This fails currently, so next commits fix it up. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
pseudorand(1) is always 0, and capacity test was the wrong way. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Without this, sendpay will refuse to pay. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Lagrang3
reviewed
Aug 31, 2023
| flow_edge(f, i)->base_fee, | ||
| flow_edge(f, i)->proportional_fee)) | ||
| flow_edge(f, i+1)->base_fee, | ||
| flow_edge(f, i+1)->proportional_fee)) |
Lagrang3
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.