CPFP for mutual close #6734
Merged
CPFP for mutual close #6734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool do any other implementations support this? |
rustyrussell
force-pushed
the
guilt/cpfp-for-mutual-close
branch
from
77c2f77
to
7db541a
Compare
I assume they all do: it's a weird CLN quirk that we didn't expose it in our wallet before confirmation. |
There was a problem hiding this comment.
CI is failing
ld lightningd/test/run-jsonrpc
/usr/bin/ld: lightningd/test/run-invoice-select-inchan.o: in function `sign_and_send_last':
/home/runner/work/lightning/lightning/lightningd/test/../peer_control.c:302: undefined reference to `wallet_extract_owned_outputs'
collect2: error: ld returned 1 exit status
make: *** [Makefile:660: lightningd/test/run-invoice-select-inchan] Error 1
make: *** Waiting for unfinished jobs....
rm external/build-x86_64-linux-gnu/libwally-core-build/src/secp256k1/libsecp256k1.la
7db541a
to
99961e6
Compare
Yep, needed to update-mocks after rebase on master... |
|
Ok now rerunning lnprototest because the following assertion looks really strange to me |
Yes, timing changes in recent commits made this worse, but it's real: we never properly waited in many cases where we send a warning, and lightningd tells connectd to hang up. Will fix |
rustyrussell
force-pushed
the
guilt/cpfp-for-mutual-close
branch
from
99961e6
to
284173e
Compare
vincenzopalazzo
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
ACK 284173e
It is missing just a rebase to see if the CI is happy again
You can't (yet): it doesn't even show in listfunds. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We had a complaint that you can't CPFP a mutual close, which you should be able to do. Fixes: ElementsProject#6692 Changelog-Fixed: wallet: close change outputs show up immediately in `listfunds` so you can CPFP. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
vincenzopalazzo
force-pushed
the
guilt/cpfp-for-mutual-close
branch
from
284173e
to
53e1a03
Compare
|
Ah, I can do it :) Trivial Rebase on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.